Posts in category QA

Quality improving slowly...

As I primarily code new features and bugfixes, I tend to do QA changes when I can. This makes the global code quality improve slowly: 

olive@Gany ~/licorn @ find . -type f -name '*.py' | xargs pylint

[...]

Global evaluation
-----------------
Your code has been rated at 3.75/10 (previous run: -1.90/10)

Locally, the quality can be much better. There are files where I spent time to experiment with pylint remarks, and this shows: 

pylint core/internals/users.py

[...]

Global evaluation
-----------------
Your code has been rated at 8.32/10 (previous run: 8.17/10)

And files where I already modified some portions of code, but not all (since I don't have time): 

pylint core/internals/configuration.py

[...]

Global evaluation
-----------------
Your code has been rated at 6.01/10 (previous run: 3.19/10)

Anyway, major QA work will occur: we have a dedicated milestone for this !

First pylint pass

The first pylint pass was a bit of depressiveness: my code rated at -7.7/10, which is quite bad. After some relatively easy work (configuring pylint for my naming conventions, and to use tab as indenter method), the code reached 2/10.

Then I worked on 3 files which didn't have much errors or warnings, just to familiarize with pylint and to be able to reach a result quickly, seiing this work as a learning period.

I was successfull : individual code quality on these files raised from 2/10 to 8.5/10, 9.5/10 and 10/10. Opening these files now in the editor shows a real change in terms of readability and global consistency.

Now that I'm familiar with pylint, I will stick to clean-coding as much as I can, and will operate a major quality re-read and re-code in a future milesone.